Fixes #233 – Set Vary response header when compression is enabled
#286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en compression is enabled
andrewhavck
reviewed
Jun 21, 2024
palant
changed the title
Vary response header when compression is enabled
andrewhavck
reviewed
Aug 9, 2024
|
Test failures are again in unrelated code. 🙄 |
|
Thanks, will look into the flaky tests. |
johnhurt
pushed a commit
that referenced
this pull request
Aug 23, 2024
…abled --- Merge branch 'main' into compression-headers --- Updated “compression enabled” check for recent changes --- Fixed clippy warning --- Reverted changes related to Accept-Ranges header --- Handle multiple Vary headers --- Merged main branch Includes-commit: 4ea0c3f Includes-commit: 78f09b2 Includes-commit: 973d596 Includes-commit: 9f82578 Includes-commit: d6e94c9 Includes-commit: e88fdb8 Includes-commit: f647f04 Replicated-from: #286
johnhurt
pushed a commit
that referenced
this pull request
Aug 23, 2024
…abled --- Merge branch 'main' into compression-headers --- Updated “compression enabled” check for recent changes --- Fixed clippy warning --- Reverted changes related to Accept-Ranges header --- Handle multiple Vary headers --- Merged main branch Includes-commit: 4ea0c3f Includes-commit: 78f09b2 Includes-commit: 973d596 Includes-commit: 9f82578 Includes-commit: d6e94c9 Includes-commit: e88fdb8 Includes-commit: f647f04 Replicated-from: #286
|
This landed in our sync today, thanks for the contribution and sorry for the delay. |
escoffier
pushed a commit
to escoffier/pingora
that referenced
this pull request
Sep 6, 2024
…en compression is enabled --- Merge branch 'main' into compression-headers --- Updated “compression enabled” check for recent changes --- Fixed clippy warning --- Reverted changes related to Accept-Ranges header --- Handle multiple Vary headers --- Merged main branch Includes-commit: 4ea0c3f Includes-commit: 78f09b2 Includes-commit: 973d596 Includes-commit: 9f82578 Includes-commit: d6e94c9 Includes-commit: e88fdb8 Includes-commit: f647f04 Replicated-from: cloudflare#286
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #229 and #233 for the rationale behind these changes.
The
Varyinsertion logic might be a bit overzealous, it will insert the header even if upstream produced an encoding that we cannot decompress. This is a rather unlikely scenario however, and having thisVaryheader won’t hurt.