(CC refactor 8) recovery: move all congestion control related fields to a new struct #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghedo
force-pushed
the
cc-refactor-7-detect-acked-epoch
branch
from
194b849
to
ed2c784
Compare
ghedo
force-pushed
the
cc-refactor-8-cc-struct
branch
from
c52ef3d
to
74d6d98
Compare
LPardue
reviewed
May 3, 2024
Comment on lines
-682
to
-683
| // To avoid rollback | ||
| r.lost_count += MIN_ROLLBACK_THRESHOLD; |
There was a problem hiding this comment.
This PR is pretty obtuse to review, so I just wanted to check, is the removal here was covered somewhere else?
There was a problem hiding this comment.
AFAICT this was never actually necessary, because the rollback doesn't happen either way.
LPardue
reviewed
May 3, 2024
Comment on lines
-1257
to
-1258
| // To avoid rollback | ||
| r.lost_count += MIN_ROLLBACK_THRESHOLD; |
There was a problem hiding this comment.
Same comment as above regarding what this removal means
ghedo
force-pushed
the
cc-refactor-8-cc-struct
branch
from
74d6d98
to
505df84
Compare
This creates a clearer separation between congestion and recovery.
ghedo
force-pushed
the
cc-refactor-8-cc-struct
branch
from
505df84
to
fb68839
Compare
LPardue
approved these changes
Jun 18, 2024
|
Merged as f73f869. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.