cubic: use appropriate byte counting #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junhochoi
force-pushed
the
cubic_byte_counting
branch
from
560d2e4
to
ccff523
Compare
junhochoi
changed the title
LPardue
reviewed
Sep 3, 2020
junhochoi
force-pushed
the
cubic_byte_counting
branch
2 times, most recently
from
0dc5d2a
to
476598e
Compare
ghedo
reviewed
Sep 11, 2020
ghedo
reviewed
Sep 11, 2020
ghedo
reviewed
Sep 11, 2020
ghedo
reviewed
Sep 11, 2020
ghedo
reviewed
Sep 11, 2020
ghedo
requested changes
Sep 11, 2020
There was a problem hiding this comment.
Added a few nits, though I haven't quite gotten my head around this change yet, so I'll need to do another pass later.
Also, I just realized I "misspelled" appropriate as accurate in the commit message for the Reno change 🤦♂️ Need to replace s/accurate/appropriate/ in the commit message in this PR.
junhochoi
force-pushed
the
cubic_byte_counting
branch
from
5c619f8
to
e9a24aa
Compare
Implements quicwg/base-drafts#3917 for CUBIC.
junhochoi
force-pushed
the
cubic_byte_counting
branch
from
e9a24aa
to
6c49f7d
Compare
ghedo
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements quicwg/base-drafts#3917 for CUBIC.