Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Build Support #70

Merged
merged 8 commits into from
Jul 9, 2019
Merged

Android Build Support #70

merged 8 commits into from
Jul 9, 2019

Conversation

junhochoi
Copy link
Contributor

Fix for #58

BoringSSL Android build instruction:
https://boringssl.googlesource.com/boringssl/+/HEAD/BUILDING.md

Note that arm64 works only.

How to build:
https://mozilla.github.io/firefox-browser-architecture/experiments/2017-09-21-rust-on-android.html

When you have installed toolchain by make_standalone_toolchain.py
and updated ~/.cargo/config, you can run build as follows:

env PATH=<path of clang>:$PATH cargo build --target aarch64-linux-android

BoringSSL Android build instruction:
https://boringssl.googlesource.com/boringssl/+/HEAD/BUILDING.md

Note that arm64 works only.

How to build:
https://mozilla.github.io/firefox-browser-architecture/experiments/2017-09-21-rust-on-android.html

When you have installed toolchain by make_standalone_toolchain.py
and updated ~/.cargo/config, you can run build as follows:

```
env PATH=<path of clang>:$PATH cargo build --target aarch64-linux-android
```
@junhochoi junhochoi requested a review from ghedo as a code owner July 3, 2019 00:48
@junhochoi junhochoi mentioned this pull request Jul 3, 2019
@junhochoi junhochoi changed the title Add parameters for BoringSSL Android build Android Build Support Jul 3, 2019
@junhochoi
Copy link
Contributor Author

Only aarch64 is tested. Need to take a look on 32-bit arm and x86 as well.

@junhochoi
Copy link
Contributor Author

junhochoi commented Jul 3, 2019

Updated with helper script and documentation.

@junhochoi
Copy link
Contributor Author

arm 32bit and x86 is able to build now - API level should be >=21 for building ring and openssl both.

src/build.rs Show resolved Hide resolved
LPardue
LPardue previously approved these changes Jul 8, 2019
Copy link
Contributor

@LPardue LPardue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm

Copy link
Member

@ghedo ghedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but added some minor suggestions to improve some wording.

tools/build_android.md Outdated Show resolved Hide resolved
src/build.rs Outdated Show resolved Hide resolved
src/build.rs Outdated Show resolved Hide resolved
src/build.rs Outdated Show resolved Hide resolved
src/build.rs Outdated Show resolved Hide resolved
tools/build_android.md Outdated Show resolved Hide resolved
tools/build_android.md Outdated Show resolved Hide resolved
tools/build_android.md Outdated Show resolved Hide resolved
tools/build_android.md Outdated Show resolved Hide resolved
junhochoi and others added 2 commits July 8, 2019 12:01
Co-Authored-By: Alessandro Ghedini <alessandro@ghedini.me>
@junhochoi
Copy link
Contributor Author

Updated with suggestions. Also rebased #71 (iOS) to sync up with this branch. Please take a look as well.

@ghedo ghedo merged commit 7688ed4 into master Jul 9, 2019
@ghedo ghedo deleted the 355.android_build branch July 18, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants