Update makefile to fix build error #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `-lquiche` instead of `-l:libquiche.a` to build.
|
traceback to this change 57e2936 |
|
Yeah, so, this forces building against the static library, because otherwise the examples would be built with the dynamic library which is not in a standard path, so the examples would fail to run. @VMatrix1900 what build error are you trying to fix with this? |
|
In my Macbook, using |
junhochoi
reviewed
Aug 5, 2019
Use .a
This reverts commit 8141094.
Co-Authored-By: Junho Choi <1229714+junhochoi@users.noreply.github.com>
ghedo
approved these changes
Aug 6, 2019
|
Merged, thanks @VMatrix1900! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
-lquicheinstead of-l:libquiche.ato build.