Skip to content
This repository has been archived by the owner on Feb 17, 2023. It is now read-only.

added contribution guidelines #2

Closed
wants to merge 1 commit into from
Closed

Conversation

irtefa
Copy link
Contributor

@irtefa irtefa commented Jan 31, 2018

No description provided.

@@ -0,0 +1,13 @@
# Contributing to recipes to Cloudflare Workers

👍🎉 First off, thanks for taking the time to contribute! 🎉👍
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer not to use emoji here.

Also the emoji show up as rectangles on my Debian Linux machine.


## How To Contribute

We welcome community contribution to this repository. To help add functionality or address issues, please take the following steps:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These instructions are basically "How do make a pull request on Github", but it's hard for the reader to tell that without reading all the steps. Perhaps we could just say "To help add functionality or address issues, create a pull request." -- and then link to some existing guide like https://help.github.com/articles/creating-a-pull-request/ for people who don't know how to do that.


👍🎉 First off, thanks for taking the time to contribute! 🎉👍

## How To Contribute
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This describes the mechanics of contributing, but I think what people will really want to know is: What kind of contributions are we expecting? It's fairly unusual to have a public repository with examples like this, so we should describe our vision for this repository so that people can understand what kind of contributions we're expecting.

@irtefa irtefa closed this Jan 31, 2018
lukeed pushed a commit that referenced this pull request Apr 29, 2022
lukeed pushed a commit that referenced this pull request Apr 29, 2022
fix: update logic to check that global values exist
@lukeed lukeed deleted the contribution-guidelines branch May 10, 2022 22:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants