Skip to content
This repository has been archived by the owner on Jul 22, 2020. It is now read-only.

Make this repo public #11

Closed
3 tasks done
prymitive opened this issue Mar 27, 2017 · 19 comments
Closed
3 tasks done

Make this repo public #11

prymitive opened this issue Mar 27, 2017 · 19 comments
Assignees
Labels

Comments

@prymitive
Copy link
Contributor

prymitive commented Mar 27, 2017

There are a few open PRs, can we open this repo once they are merged?
Are there any other outstanding issues preventing us from making it public?

Small tasks to be done once it's open:

  • Add mock data to this repo - pointless before it's marked public as we won't be able to access those files
  • Setup travis - we could use CI, travis will be easy to add
  • Build an official docker image and put it on docker hub ?
@prymitive
Copy link
Contributor Author

I guess there's one issue - we should tag a release

@prymitive prymitive added this to the 2017.3.0 milestone Mar 27, 2017
@prymitive
Copy link
Contributor Author

Created first milestone, if there's anything else we need please raise a ticket and attach it to this milestone.

@prymitive prymitive self-assigned this Mar 27, 2017
@jamesog
Copy link
Contributor

jamesog commented Mar 27, 2017

I'm happy to open this once the PRs are all merged. Your suggestions are all fine - using Travis is no problem, we already use it for many other Cloudflare repos.

@prymitive prymitive removed this from the 2017.3.0 milestone Mar 27, 2017
@prymitive
Copy link
Contributor Author

No more outstanding PRs, is everyone happy with making this repo public now? This will allow me to tag a release and complete at least first 2 points in this ticket (docker image isn't critical).

@jamesog
Copy link
Contributor

jamesog commented Mar 27, 2017

LGTM 👍

@prymitive
Copy link
Contributor Author

@mattbostock any objections?

@mattbostock
Copy link
Contributor

No objections from me. Just one question - are we going to use the timestamp format for release tags?

IMHO it'd be more useful to use semantic versioning for a public project.

@mattbostock
Copy link
Contributor

Also, minor nit, but we should definitely add a screenshot to the README. Maybe using the sample data you created?

@prymitive
Copy link
Contributor Author

prymitive commented Mar 27, 2017

I'm happy with both version schemes, @jamesog you're needed to get a quorum
I'll add a screenshot but let me add more mocked alerts, it would look kinda sad with the current set

@prymitive
Copy link
Contributor Author

Should we use v prefix for release tags and milestones? I think that v1.0 is more obvious as a tag name than 1.0, same for milestones.

@jamesog
Copy link
Contributor

jamesog commented Mar 28, 2017

Yep, I'd prefix with v.

You have your quorum. Let the code be free.

@mattbostock
Copy link
Contributor

I also agree with 'v' - I believe that's what GitHub uses by default if you create a tag manually.

@mattbostock
Copy link
Contributor

I'm thinking that, rather than v1.0, we make the first version be v0.0.1. That'll allow for changes (without worrying about backwards compatibility) while the code settles a bit.

Using SemVer, there's a big difference between pre-1.0.0 and 1.0.0 onwards:
http://semver.org/#spec-item-4

@prymitive
Copy link
Contributor Author

v0.1.0 it is, v0.0.1 sounds like a stub of a project, I think we're past that phase

@prymitive
Copy link
Contributor Author

We're done with PRs I think, I'll open the repo and setup travis

@mattbostock
Copy link
Contributor

🎉

@prymitive
Copy link
Contributor Author

prymitive commented Mar 28, 2017

Made a PR for travis - #17
I'm going to ignore docker for now and get back to it later (will raise an internal ticket for myself)

@prymitive
Copy link
Contributor Author

will deploy a new build internally and if all goes well we'll tag a release

@prymitive
Copy link
Contributor Author

Repo is public so closing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants