Implement memory tracking for handful of classes #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jasnell
commented
Feb 6, 2024
jasnell
commented
- cache
- cf-property
- form-data
- hyperdrive
- kv
- queue
* cache * cf-property * form-data * hyperdrive * kv * queue
jasnell
force-pushed
the
jsnell/even-moar-memorytracker
branch
from
54bcc23
to
3911304
Compare
hoodmane
approved these changes
Feb 6, 2024
| @@ -536,7 +536,7 @@ void MemoryTracker::trackField( | |||
| decCurrentNodeSize(sizeof(T)); | |||
| } | |||
| pushNode(nodeName.orDefault(edgeName), sizeof(T), edgeName); | |||
| for (const auto item : value) { | |||
| for (const auto& item : value) { | |||
There was a problem hiding this comment.
What does this change do? Originally were we copying the value and now we don't? So:
- The original code trigger a compile error if T doesn't have a compile error?
- If T was a large value before, we would copy each entry just to calculate it's size?
There was a problem hiding this comment.
Original was a bug. This template previously wasn't being used yet so it hadn't been caught.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.