Add fetch_standard_url compat flag #2114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dom96
approved these changes
May 13, 2024
kentonv
reviewed
May 13, 2024
Adds a compat flag that makes it so that the fetch('...') method
variant that takes a URL string, the `Request` object constructor,
and redirects will use the standard URL parser.
Unfortunately, this introduces a double parsing of the URL in order
to minimize changes to the existing implementation. It would be
nice to refactor things to avoid the double parsing at some point.
jasnell
force-pushed
the
jsnell/fetch-standard-url2
branch
from
633952c
to
938824a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a compat flag that makes it so that the fetch('...') method variant that takes a URL string, the
Requestobject constructor, and redirects will use the standard URL parser.This is not really how I would prefer to address this since, unfortunately, this introduces a double parsing and serialization of the URL in order to minimize changes to the existing implementation. It would be nicer (and very possible) to refactor things to avoid the double parsing at some point.
Fixes: #1957