feat: Allow boolean returnMetadata for Vectorize V2 queries #2596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamIdeas
reviewed
Aug 23, 2024
Comment on lines
243
to
246
| ): value is VectorizeMetadataRetrievalLevel { | ||
| ): boolean { |
There was a problem hiding this comment.
Is there a reason for this change? I think it makes sense to keep it as it was
There was a problem hiding this comment.
I changed this to get rid of a warning Invalid type "never" of template literal expression.eslint[@typescript-eslint/restrict-template-expressions](https://typescript-eslint.io/rules/restrict-template-expressions)
RamIdeas
reviewed
Aug 23, 2024
RamIdeas
approved these changes
Aug 23, 2024
garvit-gupta
force-pushed
the
garvit/NO-JIRA/vectorize-return-metadata-type
branch
from
3fbb9bf
to
fced277
Compare
jasnell
reviewed
Aug 26, 2024
jasnell
reviewed
Aug 26, 2024
| ); | ||
| if (options && options.returnMetadata) { | ||
| if ( | ||
| typeof options.returnMetadata !== 'boolean' && |
There was a problem hiding this comment.
Maybe perform this type check once?
There was a problem hiding this comment.
How would you recommend this to be refactored?
jasnell
approved these changes
Aug 26, 2024
Co-authored-by: James M Snell <jasnell@gmail.com>
anonrig
reviewed
Aug 26, 2024
anonrig
approved these changes
Aug 27, 2024
garvit-gupta
deleted the
garvit/NO-JIRA/vectorize-return-metadata-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow boolean returnMetadata for Vectorize V2 queries for backward compatibility with Vectorize V1.