Implement new URLSearchParams has and delete second argument #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The whatwg url spec was updated to add a second optional argument to delete() and has(). While it was determined that it likely didn't break browser users, the change could break at least a couple existing deployed workers so we have to gate support behind a compat flag.
Warfields
approved these changes
May 31, 2023
| urlSearchParamsDeleteHasValueArg @30 :Bool | ||
| $compatEnableFlag("urlsearchparams_delete_has_value_arg") | ||
| $compatDisableFlag("no_urlsearchparams_delete_has_value_arg") | ||
| $compatEnableDate("2023-07-01"); |
There was a problem hiding this comment.
General question for all reviewers, how do we determine when we want the date to be? Also is there any reason we don't want to set this compat date sooner?
There was a problem hiding this comment.
It's fairly arbitrary and case-by-case really. I'll usually try to go at least a month out.
ohodson
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The whatwg url spec was updated to add a second optional argument to delete() and has(). While it was determined that it likely didn't break browser users, the change could break at least a couple existing deployed workers so we have to gate support behind a compat flag.
Tests are added in the internal PR.