Added `--node-compat` to Pages Dev & Functions #1000

JacobMGEvans · 2022-05-13T21:34:26Z

pages dev <dir> & wrangler pages functions build will have a --node-compat flag powered by @esbuild-plugins/node-globals-polyfill (which in itself is powered by rollup-plugin-node-polyfills). The only difference in pages will be it does not check the wrangler.toml so the node_compat = truewill not enable it for wrangler pages functionality.

resolves #890

changeset-bot · 2022-05-13T21:34:29Z

🦋 Changeset detected

Latest commit: 3eb04d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
wrangler	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2022-05-13T21:36:04Z

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2374149528/npm-package-wrangler-1000

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1000/npm-package-wrangler-1000

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2374149528/npm-package-wrangler-1000 dev path/to/script.js

GregBrimble · 2022-05-13T21:46:39Z

Really cool to see this working, but I don't think we can merge until we have a way for people to use this in production. So that'll require either a project-level setting in the dashboard, or a Pages config file. I imagine probably the former, but the Pages team will need to confirm.

JacobMGEvans · 2022-05-13T21:49:31Z

Without --node-compat running pages dev

Stripe --node-compat in pages Function:

Route for pages Function:

JacobMGEvans · 2022-05-13T21:51:21Z

Really cool to see this working, but I don't think we can merge until we have a way for people to use this in production. So that'll require either a project-level setting in the dashboard, or a Pages config file. I imagine probably the former, but the Pages team will need to confirm.

@GregBrimble Awesome let me know what ya'll decide next week. I might need help with this one failing test anyway lol not sure why the plugin import static asset was affected by these changes

WalshyDev · 2022-05-14T05:13:42Z

Stripe --node-compat in pages Function:

You're the best Jacob!

threepointone · 2022-05-14T10:49:45Z

So cool. Looking forward to seeing this in Pages.

`pages dev <dir>` & `wrangler pages functions build` will have a `--node-compat` flag powered by @esbuild-plugins/node-globals-polyfill (which in itself is powered by rollup-plugin-node-polyfills). The only difference in `pages` will be it does not check the `wrangler.toml` so the `node_compat = true` will not enable it for `wrangler pages` functionality. resolves #890

petebacondarwin · 2022-05-24T06:08:08Z

packages/wrangler/src/pages.tsx

@@ -1579,6 +1601,12 @@ export const pages: BuilderCallback<unknown, unknown> = (yargs) => {
                type: "string",
                description: "The directory to output static assets to",
              },
+              "node-compat": {
+                describe: "Enable node.js compaitibility",


Suggested change

describe: "Enable node.js compaitibility",

describe: "Enable node.js compatibility",

petebacondarwin · 2022-05-24T06:08:26Z

packages/wrangler/src/pages.tsx

@@ -1299,6 +1303,12 @@ export const pages: BuilderCallback<unknown, unknown> = (yargs) => {
              default: false,
              description: "Auto reload HTML pages when change is detected",
            },
+            "node-compat": {
+              describe: "Enable node.js compaitibility",


Suggested change

describe: "Enable node.js compaitibility",

describe: "Enable node.js compatibility",

I'll make another PR, didn't see these comments on my phone.

petebacondarwin · 2022-05-24T06:11:29Z

packages/wrangler/src/pages.tsx

@@ -1013,7 +1017,7 @@ const createDeployment: CommandModule<
    let builtFunctions: string | undefined = undefined;
    const functionsDirectory = join(cwd(), "functions");
    if (existsSync(functionsDirectory)) {
-      const outfile = join(tmpdir(), "./functionsWorker.js");
+      const outfile = join(tmpdir(), `./functionsWorker-${Math.random()}.js`);


@GregBrimble - these changes are due to the tmpdir() function always returning the same folder, which resulted in parallel tests overwriting each other's files.

We should come up with a better solution than actually needing to write these files to disk, ideally.

Also we could consider using fs.mkdtempSync() in combination with tmpdir() to really encapsulate separate runs of Pages builds.

But for now I think this is a reasonable way to unblock this PR.

JacobMGEvans added pages Relating to Pages polish Small improvements to the experience labels May 13, 2022

JacobMGEvans requested review from GregBrimble, threepointone and petebacondarwin as code owners May 13, 2022 21:34

JacobMGEvans force-pushed the pages-node-compat branch 5 times, most recently from 9201fc0 to 89ef9a5 Compare May 13, 2022 21:43

threepointone changed the title ~~feat: Added --node-compat to Pages Dev & Functions~~ DO NOT LAND feat: Added --node-compat to Pages Dev & Functions May 15, 2022

JacobMGEvans added blocked Blocked on other work and removed blocked Blocked on other work labels May 16, 2022

JacobMGEvans force-pushed the pages-node-compat branch from 89ef9a5 to b577642 Compare May 19, 2022 20:45

JacobMGEvans requested a review from a team as a code owner May 19, 2022 20:45

JacobMGEvans changed the title ~~DO NOT LAND feat: Added --node-compat to Pages Dev & Functions~~ Added --node-compat to Pages Dev & Functions May 19, 2022

JacobMGEvans force-pushed the pages-node-compat branch 7 times, most recently from fd601ae to 8104a17 Compare May 20, 2022 18:17

JacobMGEvans force-pushed the pages-node-compat branch 22 times, most recently from a84d615 to 481c444 Compare May 23, 2022 21:50

JacobMGEvans force-pushed the pages-node-compat branch from 481c444 to 3eb04d4 Compare May 23, 2022 21:53

petebacondarwin approved these changes May 24, 2022

View reviewed changes

JacobMGEvans merged commit 5a8e8d5 into main May 24, 2022

JacobMGEvans deleted the pages-node-compat branch May 24, 2022 13:07

github-actions bot mentioned this pull request May 24, 2022

Version Packages #1078

Merged

devholic mentioned this pull request May 30, 2022

Feature Request: Support --node-compat in wrangler pages build #1074

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added `--node-compat` to Pages Dev & Functions #1000

Added `--node-compat` to Pages Dev & Functions #1000

JacobMGEvans commented May 13, 2022 •

edited

Loading

changeset-bot bot commented May 13, 2022 •

edited

Loading

github-actions bot commented May 13, 2022 •

edited

Loading

GregBrimble commented May 13, 2022

JacobMGEvans commented May 13, 2022

JacobMGEvans commented May 13, 2022 •

edited

Loading

WalshyDev commented May 14, 2022

threepointone commented May 14, 2022

petebacondarwin May 24, 2022

petebacondarwin May 24, 2022

JacobMGEvans May 24, 2022

petebacondarwin May 24, 2022

	describe: "Enable node.js compaitibility",
	describe: "Enable node.js compatibility",

Added --node-compat to Pages Dev & Functions #1000

Added --node-compat to Pages Dev & Functions #1000

Conversation

JacobMGEvans commented May 13, 2022 • edited Loading

changeset-bot bot commented May 13, 2022 • edited Loading

🦋 Changeset detected

github-actions bot commented May 13, 2022 • edited Loading

GregBrimble commented May 13, 2022

JacobMGEvans commented May 13, 2022

JacobMGEvans commented May 13, 2022 • edited Loading

WalshyDev commented May 14, 2022

threepointone commented May 14, 2022

petebacondarwin May 24, 2022

Choose a reason for hiding this comment

petebacondarwin May 24, 2022

Choose a reason for hiding this comment

JacobMGEvans May 24, 2022

Choose a reason for hiding this comment

petebacondarwin May 24, 2022

Choose a reason for hiding this comment

Added `--node-compat` to Pages Dev & Functions #1000

Added `--node-compat` to Pages Dev & Functions #1000

JacobMGEvans commented May 13, 2022 •

edited

Loading

changeset-bot bot commented May 13, 2022 •

edited

Loading

github-actions bot commented May 13, 2022 •

edited

Loading

JacobMGEvans commented May 13, 2022 •

edited

Loading