-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log size of additional modules #4198
Log size of additional modules #4198
Conversation
🦋 Changeset detectedLatest commit: 7c2da27 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6625925109/npm-package-wrangler-4198 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6625925109/npm-package-wrangler-4198 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6625925109/npm-package-wrangler-4198 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6625925109/npm-package-cloudflare-pages-shared-4198 Note that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! ✅ Maybe add a changeset?
@penalosa is this good to be merged? Looks like it might need a changeset first? |
Codecov Report
@@ Coverage Diff @@
## main #4198 +/- ##
==========================================
+ Coverage 75.37% 75.40% +0.02%
==========================================
Files 223 223
Lines 12217 12261 +44
Branches 3159 3171 +12
==========================================
+ Hits 9209 9245 +36
- Misses 3008 3016 +8
|
Fixes #1313
What this PR solves / how to test:
Log the size of additional modules uploaded as part of your worker
Associated docs issue(s)/PR(s):
Author has included the following, where applicable:
Reviewer is to perform the following, as applicable:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.