-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow marking externals in Pages Functions #5172
Conversation
🦋 Changeset detectedLatest commit: ffad408 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8625712351/npm-package-wrangler-5172 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5172/npm-package-wrangler-5172 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8625712351/npm-package-wrangler-5172 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8625712351/npm-package-create-cloudflare-5172 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8625712351/npm-package-cloudflare-kv-asset-handler-5172 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8625712351/npm-package-miniflare-5172 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8625712351/npm-package-cloudflare-pages-shared-5172 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8625712351/npm-package-cloudflare-vitest-pool-workers-5172 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5172 +/- ##
==========================================
- Coverage 72.09% 70.53% -1.56%
==========================================
Files 331 298 -33
Lines 17175 15540 -1635
Branches 4386 4000 -386
==========================================
- Hits 12382 10961 -1421
+ Misses 4793 4579 -214
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2f2ab1d
to
47d15a2
Compare
47d15a2
to
74b9bff
Compare
74b9bff
to
ffad408
Compare
What this PR solves / how to test
This allows Pages Plugins authors to mark dependencies as external when bundling their plugin. This is useful if you want to declare a module as a peer dependency.
Author has addressed the following