fix(wrangler): enforce Pages config validation around DOs #5666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 25b42b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8757768490/npm-package-wrangler-5666You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5666/npm-package-wrangler-5666Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8757768490/npm-package-wrangler-5666 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8757768490/npm-package-create-cloudflare-5666 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8757768490/npm-package-cloudflare-kv-asset-handler-5666npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8757768490/npm-package-miniflare-5666npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8757768490/npm-package-cloudflare-pages-shared-5666npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8757768490/npm-package-cloudflare-vitest-pool-workers-5666Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
CarmenPopoviciu
force-pushed
the
carmen/fix-do-bindings-for-pages-config
branch
2 times, most recently
from
3176c12
to
8d4b040
Compare
Today Pages cannot deploy Durable Objects itself. For this reason it is mandatory that when declaring Durable Objects bindings in the config file, the `script_name` is specified. We are currently not failing validation if `script_name` is not specified but we should. This commit fixes that.
CarmenPopoviciu
force-pushed
the
carmen/fix-do-bindings-for-pages-config
branch
from
8d4b040
to
25b42b3
Compare
penalosa
approved these changes
Apr 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test
Today Pages cannot deploy Durable Objects itself. For this reason it is mandatory that when declaring Durable Objects
bindings in the config file, the
script_nameis specified. We are currently not failing validation ifscript_nameisnot specified but we should. This PR fixes that.
Fixes DEVX-1266
Author has addressed the following