This repository has been archived by the owner on Feb 7, 2023. It is now read-only.
Make DocumentHandler optionals #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also ran into this. I wouldn't normally bump a PR, but we're enterprise customers so we're paying for this hehe 🤡 If Cloudflare is interested in including more outside maintainers of these types, I'd be willing to help! I know it can be hard to keep up. |
|
Hi Jay, I've recently been (re)hired by Cloudflare, so hopefully I can chase things up for you. Looks like this PR would actually break implementations where you define a class: // A class can only implement an object type or intersection of object types with statically known members. ts(2422)
class MyDocumentHandler implements DocumentHandler {
doctype() {}
}And that means of course, that new HTMLRewriter().onDocument({
doctype() {}
})I'll play around with it this weekend/next week and see if there's anything I can do to make that work for everyone. |
Merged
threepointone
added a commit
that referenced
this pull request
Sep 30, 2021
Auto-Generated Types Types are now automatically generated with releases by parsing the runtime's source code, and merging in overrides/docs defined in this repository (for generics, overloads, comments, etc). webworker no longer needs to (and shouldn't) be included in tsconfig lib. The final merged AST that's used to render the TypeScript types, workers.json, is also included in the repository. This could be used to generate bindings for other languages that compile to WebAssembly. Rust output is coming soon. Closes: #55, #75, #76, #81, #84, #96, #97, #100, #101, #102, #105, #106, #107, #108
|
#112 has now been merged, which makes all members optional. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like
ElementHandler,DocumentHandler's various functions should be optional, requiring only one of them.