This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Don't panic when the user isn't logged in #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example warning:
```
warning: `todo` should not be present in production code
--> src/settings/toml/manifest.rs:597:13
|
597 | todo!()
| ^^^^^^^
|
note: the lint level is defined here
--> src/lib.rs:2:9
|
2 | #![warn(clippy::todo)] // TODO(jyn514): remove this once clippy warns about it by default
| ^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#todo
= note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
```
This was referenced Jul 26, 2021
Closed
It could never fail; this made it easier to tell how GlobalUser::new could fail.
Previously, `wrangler dev` would panic if `~/.wrangler/config.toml` didn't exist (or had a syntax error).
jyn514
force-pushed
the
jnelson/account-todo
branch
from
95b8cfa
to
6c56851
Compare
nataliescottdavidson
approved these changes
Jul 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
wrangler devwould panic if~/.wrangler/config.tomldidn't exist(or had a syntax error).
Follow-up to #1966.