This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
force-pushed
the
avery/environments
branch
from
August 5, 2019 20:11
3b04386
to
911b764
Compare
EverlastingBugstopper
force-pushed
the
avery/environments
branch
4 times, most recently
from
August 9, 2019 21:14
03d5393
to
7986420
Compare
…nvironment table from toml
EverlastingBugstopper
force-pushed
the
avery/environments
branch
from
August 9, 2019 21:14
7986420
to
4b08be8
Compare
EverlastingBugstopper
changed the title
[WIP] Add test for building with multiple environments
[WIP] Add support with multiple environments
Aug 9, 2019
EverlastingBugstopper
force-pushed
the
avery/environments
branch
from
August 12, 2019 22:12
08f3e45
to
1632a9d
Compare
Refactor environment parsing
Environments Documentation
EverlastingBugstopper
added
status - needs review
regression
Something is broken, but works in previous releases
and removed
status - work in progress
labels
Sep 9, 2019
ashleymichal
approved these changes
Sep 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one weird comment on a result ?
that appears impossible to hit in this implementation so prolly is fine.
gabbifish
approved these changes
Sep 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is an amalgamation of smaller PRs I have already approved, reading through this didn't surface much for me to comment on. LGTM!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add the feature described in #385.
TL;DR: Wrangler users want to be able to push their same workers project to multiple places, perhaps they have a production, staging, and dev worker. This PR allows them to do so with the introduction of the
--env
flag and some changes towrangler.toml
. Most notably,private
has been deprecated,workers_dot_dev
has been added as a boolean field, and you can specify new environments with[env.foo]
. To read more, please see this document.Contains
wrangler.toml
--release
--env
or-e
forwrangler publish
from command lineworkers_dot_dev
towrangler.toml
wrangler.toml
and inherit throughout each environmentProject
toTarget
, the reasoning behind this is thatProject
seems to describe an entire codebase, when what we're really doing is passing around an object that specifies where the worker is deployed to -- seems likeTarget
is a more suitable name.Completed issues
Fixes #357, #385, #388