Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

prohibit upload of directory named node_modules #792

Merged
merged 1 commit into from
Oct 21, 2019
Merged

prohibit upload of directory named node_modules #792

merged 1 commit into from
Oct 21, 2019

Conversation

gabbifish
Copy link
Contributor

Closes #723

@gabbifish gabbifish added status - needs review regression Something is broken, but works in previous releases labels Oct 21, 2019
EverlastingBugstopper
EverlastingBugstopper approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perf

@gabbifish gabbifish merged commit 80c9bfc into master Oct 21, 2019
@exvuma exvuma added feature Feature requests and suggestions changelog - feature and removed feature Feature requests and suggestions labels Oct 25, 2019
@EverlastingBugstopper EverlastingBugstopper added this to the 1.5.0 milestone Oct 25, 2019
@ashleymichal ashleymichal deleted the gabbi/fix-#723 branch November 6, 2019 22:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EverlastingBugstopper EverlastingBugstopper EverlastingBugstopper approved these changes

@ashleymichal ashleymichal Awaiting requested review from ashleymichal

Assignees
No one assigned
Labels
regression Something is broken, but works in previous releases
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Prevent bucket from being set to node_modules
3 participants
@gabbifish @EverlastingBugstopper @exvuma