This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Provide helpful error when user accidentally puts kv-namespace information under [site] #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabbifish
commented
Dec 7, 2019
src/settings/target/manifest.rs
Outdated
| let manifest: Manifest = match config.try_into() { | ||
| Ok(m) => m, | ||
| Err(e) => { | ||
| if e.to_string().contains("unknown field `kv-namespaces`") { |
There was a problem hiding this comment.
if there's a nicer way to match on the specific error thrown by serde when the #[serde(deny_unknown_fields)] condition is triggered, I'm all ears!
ashleymichal
approved these changes
Dec 11, 2019
EverlastingBugstopper
approved these changes
Dec 11, 2019
ashleymichal
pushed a commit
that referenced
this pull request
Dec 13, 2019
…ation under [site] (#937) * Provide helpful error when user accidentally puts kv-namespace information under [site] * improve error messaging
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #798.
If someone provides a wrangler.toml with
we now provide an error message on any
wranglercommand:I wanted to set up TOML serialization so that
[site]would be an inline TOML table (so there would be no reasonable way to putkv-namespaceswithinsite!) but alas, inline TOML table serialization isn't supported by the serde TOML serializer yet.