Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature DataSourceAccount for cost routing #202

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Conversation

ImMin5
Copy link
Member

@ImMin5 ImMin5 commented Apr 24, 2024

Category

  • New feature
  • Bug fix
  • Improvement
  • Refactor
  • etc

Description

  • add feature DataSourceAccount for cost routing

Known issue

@ImMin5 ImMin5 added the enhancement New feature or request label Apr 24, 2024
@ImMin5 ImMin5 self-assigned this Apr 24, 2024
@ImMin5 ImMin5 merged commit bdd3101 into master Apr 24, 2024
1 of 2 checks passed
Copy link

⚠️ @ImMin5 the signed-off-by was not found in the following 4 commits:

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

"Secret.delete", {"secret_id": secret_id}
)
except ERROR_INTERNAL_API:
_LOGGER.info(f"[delete_secret] Secret is already deleted. ({secret_id})")

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information High

This expression logs
sensitive data (secret)
as clear text.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fail/signedoff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant