This repository has been archived by the owner on Jan 25, 2022. It is now read-only.
Update ltc to include router group guid in tcp routes. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey fordaz! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/106994940. |
davidwadden
force-pushed
the
ltc-router-group-guid
branch
from
c1c94ac
to
8d776d8
Compare
|
This commit got rebased but the origin branch to pull from was not force pushed properly |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add RouterGroupGuid in TCP Routes when creating an LRP as RouterGroupGuid is now required by routing-api. Bumping of cf-routing-release (cloudfoundry-attic/lattice-release#228) needs these changes to
ltcto make sure all the required data is passed for tcp routes.Since there is only one router group supported as of now in tcp router, we are passing the hardcoded value of router group guid.
Regards,
@fordaz and @atulkc
(CF Routing team)