This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found cloudfoundry/vcap components use 'port'/'user'/'password' for status server configuration,whereas cloudfoundry/vcap-services use 'port'/'username'/'password'.
It does not matter which to use 'user' or 'username' but it would be better to use the same format to reduce configuration errors.
I think 'username' would be better but all vcap components already use 'user' as the name, which I took in
Thanks.Dear Cloud Foundry contributor,
If you are reading this message, it means you submitted a pull request in the Cloud Foundry GitHub repository.
First of all, thanks! We really appreciate your participation.
Recently we made some changes in how we are verifying and reviewing open source contributions like yours. In addition, we changed the way we can expose our internal development in real-time. The changes are exciting, as they allow all our staff to collaborate seamlessly with you, which increases our mutual velocity and gives the community a bigger stake in our direction.
The Cloud Foundry team uses Gerrit, a code review tool that originated in the Android Open Source Project. We also use GitHub as an official mirror, though all pull requests are accepted via Gerrit.
Follow these steps to make a contribution to any of our open source repositories:
Complete our CLA Agreement for
individuals or
corporations.
Sign up for an account on our public Gerrit server at
http://reviews.cloudfoundry.org/.
Create and upload your public SSH key in your Gerrit account profile.
Set your name and email:
Install our gerrit-cli gem:
Clone the Cloud Foundry repo:
Note: to clone the BOSH repo, or the Documentation repo, replace
vcap
withbosh
oross-docs
Make your changes, commit, and push to gerrit:
Once your commits are approved by our Continuous Integration Bot (CI Bot) as well as our engineering staff, return to the Gerrit interface and MERGE your changes. The merge will be replicated to GitHub automatically at https://github.com/cloudfoundry. If you get feedback on your submission, we recommend squashing your commit with the original change-id. See the squashing section here for more details: https://help.github.com/rebase.