Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

configuration format improvement #13

Closed
wants to merge 2 commits into from

Conversation

yssk22r
Copy link

@yssk22r yssk22r commented Dec 10, 2011

I found cloudfoundry/vcap components use 'port'/'user'/'password' for status server configuration,whereas cloudfoundry/vcap-services use 'port'/'username'/'password'.

It does not matter which to use 'user' or 'username' but it would be better to use the same format to reduce configuration errors.

I think 'username' would be better but all vcap components already use 'user' as the name, which I took in

Thanks.Dear Cloud Foundry contributor,

If you are reading this message, it means you submitted a pull request in the Cloud Foundry GitHub repository.

First of all, thanks! We really appreciate your participation.

Recently we made some changes in how we are verifying and reviewing open source contributions like yours. In addition, we changed the way we can expose our internal development in real-time. The changes are exciting, as they allow all our staff to collaborate seamlessly with you, which increases our mutual velocity and gives the community a bigger stake in our direction.

The Cloud Foundry team uses Gerrit, a code review tool that originated in the Android Open Source Project. We also use GitHub as an official mirror, though all pull requests are accepted via Gerrit.

Follow these steps to make a contribution to any of our open source repositories:

  1. Complete our CLA Agreement for
    individuals or
    corporations.

  2. Sign up for an account on our public Gerrit server at
    http://reviews.cloudfoundry.org/.

  3. Create and upload your public SSH key in your Gerrit account profile.

  4. Set your name and email:

            git config --global user.name "Firstname Lastname"
            git config --global user.email "your_email@youremail.com"
    
  5. Install our gerrit-cli gem:

            gem install gerrit-cli
    
  6. Clone the Cloud Foundry repo:
    Note: to clone the BOSH repo, or the Documentation repo, replace
    vcap with bosh or oss-docs

            gerrit clone ssh://reviews.cloudfoundry.org:29418/vcap
            cd vcap
    
  7. Make your changes, commit, and push to gerrit:

            git commit
            gerrit push
    

Once your commits are approved by our Continuous Integration Bot (CI Bot) as well as our engineering staff, return to the Gerrit interface and MERGE your changes. The merge will be replicated to GitHub automatically at https://github.com/cloudfoundry. If you get feedback on your submission, we recommend squashing your commit with the original change-id. See the squashing section here for more details: https://help.github.com/rebase.

Yohei Sasaki added 2 commits December 10, 2011 22:25
…reas cloudfoundry/vcap-services use 'port'/'username'/'password'.


It does not matter to use 'user' or 'username' but it would be better to use the same format for status server configuration to reduce invalid configuration.

thanks.
@yssk22r
Copy link
Author

yssk22r commented Dec 10, 2011

I also found :username is not used in VCAP::Component#register, so that this is a bug fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants