Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

Add createWatchNamespace helm variable #30

Merged
merged 1 commit into from
Nov 28, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deploy/helm/quarks-job/templates/namespace.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if .Values.global.operator.watchNamespace }}
{{- if and .Values.global.operator.watchNamespace .Values.createWatchNamespace }}
---
apiVersion: v1
kind: Namespace
Expand Down
2 changes: 2 additions & 0 deletions deploy/helm/quarks-job/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ nameOverride: ""

fullnameOverride: ""

createWatchNamespace: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createWatchedNamespace? Not sure if it's correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the correct word. But I think createWatchNamespace is fine.


serviceAccount:
quarksJobServiceAccount:
create: true
Expand Down
1 change: 1 addition & 0 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,4 @@ require (
)

go 1.13