Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(direnv): Check if devbox is installed before invoking it #2921

Merged
merged 2 commits into from
May 6, 2024

Conversation

silvestre
Copy link
Member

@silvestre silvestre commented May 3, 2024

Issue

If you don't have devbox installed the .envrc would error out.

Fix

First check for devbox and then nix, restoring plain Nix usage as
well.

Issue

The package definitions for app-autoscaler-cli-plugin and
bosh-bootloader were duplicated in the root and local-flake flakes.

Fix

Reuse local-flake package definitions in main flake

@silvestre silvestre requested a review from joergdw May 3, 2024 14:26
@silvestre silvestre changed the title feat(direnv): Checks if devbox is installed before invoking it feat(direnv): Check if devbox is installed before invoking it May 3, 2024
# Issue

If you don't have `devbox` installed the `.envrc` would error out.

# Fix

First check for `devbox` and then `nix`, restoring plain Nix usage as
well.
# Issue

The package definitions for `app-autoscaler-cli-plugin` and
`bosh-bootloader` were duplicated in the root and `local-flake` flakes.

# Fix

Reuse `local-flake` package definitions in main flake
Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@silvestre silvestre added exclude-from-changelog bug allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. labels May 6, 2024
@silvestre silvestre enabled auto-merge (squash) May 6, 2024 13:37
@silvestre silvestre merged commit 5ec165c into main May 6, 2024
36 of 39 checks passed
@silvestre silvestre deleted the check-for-devbox-first branch May 6, 2024 14:53
bonzofenix pushed a commit that referenced this pull request May 21, 2024
* feat(direnv): Checks if `devbox` is installed before invoking it

# Issue

If you don't have `devbox` installed the `.envrc` would error out.

# Fix

First check for `devbox` and then `nix`, restoring plain Nix usage as
well.

* fix(flake): Reuse `local-flake` package definitions in main flake

# Issue

The package definitions for `app-autoscaler-cli-plugin` and
`bosh-bootloader` were duplicated in the root and `local-flake` flakes.

# Fix

Reuse `local-flake` package definitions in main flake
bonzofenix pushed a commit that referenced this pull request May 21, 2024
* feat(direnv): Checks if `devbox` is installed before invoking it

# Issue

If you don't have `devbox` installed the `.envrc` would error out.

# Fix

First check for `devbox` and then `nix`, restoring plain Nix usage as
well.

* fix(flake): Reuse `local-flake` package definitions in main flake

# Issue

The package definitions for `app-autoscaler-cli-plugin` and
`bosh-bootloader` were duplicated in the root and `local-flake` flakes.

# Fix

Reuse `local-flake` package definitions in main flake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. bug exclude-from-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants