Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poc(metricsforwarder): Deploy metricsforwarder as a cf app #2967

Merged
merged 82 commits into from
Jun 13, 2024

Conversation

bonzofenix
Copy link
Contributor

@bonzofenix bonzofenix commented May 30, 2024

Goal:

Evaluate if it is possible to run acceptance test suite with metricsforwarder running on CF

Solution:

  • Establish a concourse pipeline that deploys metrics forwarder to CF before running acceptance test
  • Ignore mutual ssl from DB connections within the cluster and also metric forwarder.
  • Add an operation file that enables a non production mixed solution with bosh deploying app autoscaler and deploying separately metrics forwarder on CF as a cloudfoundry app.

Working build this latest changes: https://concourse.app-runtime-interfaces.ci.cloudfoundry.org/teams/app-autoscaler/pipelines/app-autoscaler-release-metricsforwarder-cf-deployment/jobs/acceptance-log-cache-syslog-cf/builds/49


NOTE: This PoC is not intended for production usage, for this the following task need to be implemented (out of the scope of this pr)

  • Allowing DB to ignore sans instead of ignoring SSL altogether
  • Configure multiapps-controller on OSS CF infrastructure
  • Configuring deployment through MTAR

@bonzofenix bonzofenix added allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. skip-cleanup labels May 30, 2024
@bonzofenix bonzofenix force-pushed the metricsforwarder-cf-deployment branch from f3f689c to b7299f7 Compare May 30, 2024 16:20
@bonzofenix bonzofenix force-pushed the metricsforwarder-cf-deployment branch from ce00bc1 to cc3f4ef Compare June 3, 2024 09:56
@bonzofenix bonzofenix force-pushed the metricsforwarder-cf-deployment branch from 81eb826 to c1cf090 Compare June 3, 2024 11:07
@bonzofenix bonzofenix removed the allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. label Jun 3, 2024
@bonzofenix bonzofenix force-pushed the metricsforwarder-cf-deployment branch from 0a5747e to 980f42a Compare June 4, 2024 10:40
@bonzofenix bonzofenix force-pushed the metricsforwarder-cf-deployment branch 11 times, most recently from d47cd84 to 860583c Compare June 4, 2024 15:02
@bonzofenix bonzofenix force-pushed the metricsforwarder-cf-deployment branch from 1777d6b to a55ee4e Compare June 11, 2024 11:46
@bonzofenix bonzofenix force-pushed the metricsforwarder-cf-deployment branch 8 times, most recently from 7a742d6 to 40fb38b Compare June 12, 2024 14:09
@bonzofenix bonzofenix force-pushed the metricsforwarder-cf-deployment branch from 40fb38b to ab162c8 Compare June 12, 2024 14:30
Copy link
Contributor

@joergdw joergdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Just a small question below.

ci/scripts/delete-pipeline.sh Show resolved Hide resolved
Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@bonzofenix bonzofenix merged commit 74434bd into main Jun 13, 2024
29 of 30 checks passed
@bonzofenix bonzofenix deleted the metricsforwarder-cf-deployment branch June 13, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. skip-cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants