-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
poc(metricsforwarder): Deploy metricsforwarder as a cf app #2967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonzofenix
added
allow-acceptance-tests
This label needs to be added to enable the acceptance tests to run.
skip-cleanup
labels
May 30, 2024
bonzofenix
force-pushed
the
metricsforwarder-cf-deployment
branch
from
May 30, 2024 16:20
f3f689c
to
b7299f7
Compare
src/acceptance/assets/app/go_app/internal/app/custom_metrics.go
Outdated
Show resolved
Hide resolved
bonzofenix
force-pushed
the
metricsforwarder-cf-deployment
branch
from
June 3, 2024 09:56
ce00bc1
to
cc3f4ef
Compare
src/acceptance/assets/app/go_app/internal/app/custom_metrics.go
Outdated
Show resolved
Hide resolved
src/acceptance/assets/app/go_app/internal/app/custom_metrics.go
Outdated
Show resolved
Hide resolved
bonzofenix
force-pushed
the
metricsforwarder-cf-deployment
branch
from
June 3, 2024 11:07
81eb826
to
c1cf090
Compare
bonzofenix
removed
the
allow-acceptance-tests
This label needs to be added to enable the acceptance tests to run.
label
Jun 3, 2024
bonzofenix
force-pushed
the
metricsforwarder-cf-deployment
branch
from
June 4, 2024 10:40
0a5747e
to
980f42a
Compare
bonzofenix
force-pushed
the
metricsforwarder-cf-deployment
branch
11 times, most recently
from
June 4, 2024 15:02
d47cd84
to
860583c
Compare
Co-authored-by: joergdw <joerg.weisbarth@sap.com>
Co-authored-by: joergdw <joerg.weisbarth@sap.com>
bonzofenix
force-pushed
the
metricsforwarder-cf-deployment
branch
from
June 11, 2024 11:46
1777d6b
to
a55ee4e
Compare
bonzofenix
force-pushed
the
metricsforwarder-cf-deployment
branch
8 times, most recently
from
June 12, 2024 14:09
7a742d6
to
40fb38b
Compare
bonzofenix
force-pushed
the
metricsforwarder-cf-deployment
branch
from
June 12, 2024 14:30
40fb38b
to
ab162c8
Compare
joergdw
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. Just a small question below.
src/acceptance/assets/app/go_app/internal/app/custom_metrics.go
Outdated
Show resolved
Hide resolved
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
allow-acceptance-tests
This label needs to be added to enable the acceptance tests to run.
skip-cleanup
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal:
Evaluate if it is possible to run acceptance test suite with metricsforwarder running on CF
Solution:
Working build this latest changes: https://concourse.app-runtime-interfaces.ci.cloudfoundry.org/teams/app-autoscaler/pipelines/app-autoscaler-release-metricsforwarder-cf-deployment/jobs/acceptance-log-cache-syslog-cf/builds/49
NOTE: This PoC is not intended for production usage, for this the following task need to be implemented (out of the scope of this pr)