Typo in buildpack names

[acohen716]

binary-buildpack/bin/release.bat

Line 4 in ec05f7e

set message=Warning: We detected a Web.config in your app. This probably means that you want to use the hwc-buildpack. If you really want to use the binary-buildpack, you must specify a start command.

hwc-buildpack should be hwc_buildpack and binary-buildpack should be binary_buildpack

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/162625493

The labels on this github issue will be updated when the story is started.

[sclevine]

hwc_buildpack and binary_buildpack often identify the default system buildpacks on a deployment of Cloud Foundry, but in other contexts we use - to separate parts of the buildpack names.

(There is no guarantee that these buildpacks will be identified as hwc_buildpack and binary_buildpack in CF, especially if more than one version is available.)

[acohen716]

Thanks for the clarification. Since it's the default, shouldn't it use the _? Taking a look at the HWC Buildpack push an app documentation, it specifies cf push APP-NAME -s windows2016 -b hwc_buildpack. Taking a look at the Binary Buildpack push an app documentation, it specifies cf push my_app -c './app' -b binary_buildpack. This has come up in a workshop for students that are new to CF and push a .NET app using the binary_buildpack and not the hwc_builpack. Based on the error message they then try hwc-buildpack which doesn't exist. An alternative might be to use a space to separate and a recommendation to run cf buildpacks to find the exact builpack name?

[sclevine]

We would accept a PR that changed the phrasing to "Binary Buildpack" and "HWC Buildpack"

[tylerphelan]

Fixed on develop and will be in the next release!

[acohen716]

Thanks I see it here: 7382274