Allow importing bosh-cli v7 as a dependency #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[#182248334] bosh-cli was using Gopkg for dependency management until v6.4.1 In v6.4.2 bosh-cli was migrated to use go-modules but module path was maintained as "github.com/cloudfoundry/bosh-cli" However, go-modules require package path to include a reference to the MAJOR increment from the semver version number https://go.dev/doc/modules/release-workflow#breaking Without such modification to the module path golang refuses to install the module as a third-party dependency and complains about a mismatch between the MAJOR version and the module path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#182248334]
bosh-cli was using Gopkg for dependency management until v6.4.1
In v6.4.2 bosh-cli was migrated to use go-modules but module
path was maintained as "github.com/cloudfoundry/bosh-cli"
However, go-modules require package path to include a
reference to the MAJOR increment from the semver version number
https://go.dev/doc/modules/release-workflow#breaking
Without such modification to the module path golang refuses to
install the module as a third-party dependency and complains
about a mismatch between the MAJOR version and the module path.