Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow importing bosh-cli v7 as a dependency #596

Merged
merged 2 commits into from
Jun 1, 2022
Merged

Allow importing bosh-cli v7 as a dependency #596

merged 2 commits into from
Jun 1, 2022

Conversation

fnaranjo-vmw
Copy link
Contributor

[#182248334]

bosh-cli was using Gopkg for dependency management until v6.4.1
In v6.4.2 bosh-cli was migrated to use go-modules but module
path was maintained as "github.com/cloudfoundry/bosh-cli"

However, go-modules require package path to include a
reference to the MAJOR increment from the semver version number
https://go.dev/doc/modules/release-workflow#breaking

Without such modification to the module path golang refuses to
install the module as a third-party dependency and complains
about a mismatch between the MAJOR version and the module path.

[#182248334]

bosh-cli was using Gopkg for dependency management until v6.4.1
In v6.4.2 bosh-cli was migrated to use go-modules but module
path was maintained as "github.com/cloudfoundry/bosh-cli"

However, go-modules require package path to include a
reference to the MAJOR increment from the semver version number
https://go.dev/doc/modules/release-workflow#breaking

Without such modification to the module path golang refuses to
install the module as a third-party dependency and complains
about a mismatch between the MAJOR version and the module path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants