Add ops file to enable HTTP/2 routing #938
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! 👀 |
Gerg
force-pushed
the
enable_http2_ops_file
branch
from
ed94e93
to
330feba
Compare
- Should no longer be needed after cloudfoundry/routing-release#215 is merged [cloudfoundry/routing-release#200] Authored-by: Greg Cobb <gcobb@pivotal.io>
Gerg
force-pushed
the
enable_http2_ops_file
branch
from
330feba
to
62e627d
Compare
|
Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! 👀 |
|
@davewalter This ops file won't be needed when a routing release with cloudfoundry/routing-release#215 is released and included in cf-deployment. I was submitting this PR as an option to unblock cloudfoundry/cf-acceptance-tests#473 before that routing release is available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merged
Overall HTTP/2 issue: cloudfoundry/routing-release#200
Authored-by: Greg Cobb gcobb@pivotal.io
Please take a moment to review the questions before submitting the PR
WHAT is this change about?
Has a cf-deployment including this change passed cf-acceptance-tests?
Does this PR introduce a breaking change? Please take a moment to read through the examples before answering the question.
How should this change be described in cf-deployment release notes?
Does this PR introduce a new BOSH release into the base cf-deployment.yml manifest or any ops-files?
Does this PR make a change to an experimental or GA'd feature/component?
Please provide Acceptance Criteria for this change?
What is the level of urgency for publishing this change?