Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cpu_entitlement metric, allow filtering #109

Merged

Conversation

acrmp
Copy link
Member

@acrmp acrmp commented Jan 25, 2024

Please provide the following information:

What is this change about?

  • Add a new CPU Entitlement metric. The new metric better represents how much CPU an app is using relative to how much it is entitled to, instead of how much there is on the diego cell. Representing as a gauge for ease of use as the existing absolute CPU entitlement metrics are more difficult to consume.
  • Add generic filtering to app container metrics. We will use this to optionally filter the absolute_entitlement and absolute_usage metrics.

What problem it is trying to solve?

Makes it easier for metric consumers to see the CPU entitlement used at a point in time.

What is the impact if the change is not made?

It will be more difficult to determine the CPU entitlement.

How should this change be described in diego-release release notes?

Add cpu_entitlement metric.

Please provide any contextual information.

Note that the metric filtering added here doesn't allow you to exclude all of the metrics. Metrics needed for the v1 container metric can't be excluded, and neither currently can the log rate limit metrics.

cloudfoundry/diego-release#897

Tag your pair, your PM, and/or team!

@rroberts2222 @mkocher

Thank you!

- CPU Entitlement metric better represents how much CPU an app is using
  relative to how much it is entitled to, instead of how much there is
  on the diego cell. Representing as a gauge for ease of use.
- Add generic filtering to app container metrics. We will use this to
  optionally filter the absolute_entitlement and absolute_usage metrics.

Signed-off-by: Rebecca Roberts <rebecca.roberts@broadcom.com>
@winkingturtle-vmw winkingturtle-vmw merged commit 4a8e1f6 into cloudfoundry:main Jan 29, 2024
1 check passed
@acrmp acrmp deleted the cpu-entitlement-percent branch January 29, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants