Add cpu_entitlement metric, allow filtering #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- CPU Entitlement metric better represents how much CPU an app is using relative to how much it is entitled to, instead of how much there is on the diego cell. Representing as a gauge for ease of use. - Add generic filtering to app container metrics. We will use this to optionally filter the absolute_entitlement and absolute_usage metrics. Signed-off-by: Rebecca Roberts <rebecca.roberts@broadcom.com>
winkingturtle-vmw
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide the following information:
What is this change about?
What problem it is trying to solve?
Makes it easier for metric consumers to see the CPU entitlement used at a point in time.
What is the impact if the change is not made?
It will be more difficult to determine the CPU entitlement.
How should this change be described in diego-release release notes?
Add cpu_entitlement metric.
Please provide any contextual information.
Note that the metric filtering added here doesn't allow you to exclude all of the metrics. Metrics needed for the v1 container metric can't be excluded, and neither currently can the log rate limit metrics.
cloudfoundry/diego-release#897
Tag your pair, your PM, and/or team!
@rroberts2222 @mkocher
Thank you!