Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap this repo as a kubebuilder project and add the CRDs defined in previous work #1

Closed
matt-royal opened this issue Aug 16, 2021 · 1 comment
Assignees
Labels

Comments

@matt-royal
Copy link
Member

matt-royal commented Aug 16, 2021

To enable future work, we need this codebase to be set up as a kubebuilder project that contains the Custom Resource Definitions described in cloudfoundry/cf-crd-explorations#67

Acceptance Criteria

GIVEN that I am targeting a kubernetes cluster
AND   that I have this repository checked out locally
WHEN I run "make install" in this repo
AND  I run `kubectl api-resources`
THEN I see all of the CF-prefixed resources listed
WHEN I inspect each resource
THEN I see that it matches what we agreed upon in cf-crd-explorations pull request 67
AND  also I should see that there are example resource definitions in the `samples` directory for each CRD kind.

Dev Notes

Use the CRDs from cloudfoundry/cf-crd-explorations#67, but don't treat it being shared with the community as a blocker

No unit tests should be necessary for this work.

For the CRDs, mark which fields are required, valid enum types, and any other API schema constraints that apply.

@angelachin
Copy link
Contributor

@matt-royal @gnovv @akrishna90 while doing acceptance, I noted that some of the samples have the cf prefix and others don't. Can we standardize on a single format?

Otherwise, this looks good to accept to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

4 participants