Honor all relevant flags in lagerflags.New #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, lagerflags.New would honor only the logLevel flag. This change uses the ConfigFromFlags helper to extract all the relevant flags into one config and then passes it to NewFromConfig so that the invocations are automatically consistent. Since the default value for the timeFormat package variable is 0, corresponding to FormatUnixEpoch, and since the default value for redactSecrets is false, this default configuration is consistent with the previous hard-coded behavior.
|
✅ Hey emalm! The commit authors and yourself have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/162942163 The labels on this github issue will be updated when the story is started. |
cf-gitbot
added
in progress
delivered
accepted
and removed
in progress
delivered
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, lagerflags.New would honor only the logLevel flag. This change uses the ConfigFromFlags helper to extract all the relevant flags into one config and then passes it to NewFromConfig so that the invocations are automatically consistent.
Since the default value for the timeFormat package variable is 0, corresponding to FormatUnixEpoch, and since the default value for redactSecrets is false, this default configuration is consistent with the previous hard-coded behavior.