Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor all relevant flags in lagerflags.New #37

Merged
merged 1 commit into from
Jan 15, 2019

Conversation

emalm
Copy link
Member

@emalm emalm commented Jan 3, 2019

Previously, lagerflags.New would honor only the logLevel flag. This change uses the ConfigFromFlags helper to extract all the relevant flags into one config and then passes it to NewFromConfig so that the invocations are automatically consistent.

Since the default value for the timeFormat package variable is 0, corresponding to FormatUnixEpoch, and since the default value for redactSecrets is false, this default configuration is consistent with the previous hard-coded behavior.

Previously, lagerflags.New would honor only the logLevel flag. This change uses the ConfigFromFlags helper to extract all the relevant flags into one config and then passes it to NewFromConfig so that the invocations are automatically consistent.

Since the default value for the timeFormat package variable is 0, corresponding to FormatUnixEpoch, and since the default value for redactSecrets is false, this default configuration is consistent with the previous hard-coded behavior.
@cfdreddbot
Copy link

✅ Hey emalm! The commit authors and yourself have already signed the CLA.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/162942163

The labels on this github issue will be updated when the story is started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants