Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Fix fetching of stats in app wall for some cases when list is maxed #3360

Merged
merged 1 commit into from
Jan 18, 2019

Conversation

richard-cox
Copy link
Contributor

@richard-cox richard-cox commented Jan 17, 2019

@cfdreddbot
Copy link

✅ Hey richard-cox! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented Jan 17, 2019

Codecov Report

Merging #3360 into v2-master will decrease coverage by 0.47%.
The diff coverage is 68.88%.

@@             Coverage Diff              @@
##           v2-master   #3360      +/-   ##
============================================
- Coverage      70.97%   70.5%   -0.48%     
============================================
  Files            661     661              
  Lines          29173   29174       +1     
  Branches        6665    6662       -3     
============================================
- Hits           20706   20569     -137     
- Misses          8467    8605     +138

@richard-cox richard-cox changed the base branch from v2-master to add-metrics January 18, 2019 13:12
@richard-cox richard-cox changed the base branch from add-metrics to v2-master January 18, 2019 13:12
@KlapTrap KlapTrap self-requested a review January 18, 2019 13:38
@KlapTrap KlapTrap merged commit 52041f8 into v2-master Jan 18, 2019
@KlapTrap KlapTrap deleted the fix-stats-call branch January 18, 2019 14:03
KlapTrap added a commit that referenced this pull request Jan 29, 2019
* v2-master: (34 commits)
  v2/v3 api docs updates
  Fix create-services script used to set CF up for E2E tests
  Only prevent copy & paste in confirm dialog for production
  Fix for bug causing intermittment E2E Test failures on org tests (#3366)
  Allow e2e createService 3 attempts at creating service
  Weekly updaye 18 January (#3365)
  Change log for 2.3.0 (#3364)
  Ensure the loading indicator and the refresh button animated at the correct time. (#3363)
  Fix fetching of stats in app wall for some cases when list is maxed (#3360)
  Fix CF-Level Metrics permissions check (#3348)
  About Page Title customization support (#3356)
  Revert loading indicator fixes
  Fix app state to allow start action for offline while updating (#3350)
  Fix display of percent tooltip on metrics chart (#3361)
  Ensure the SCM type is included in store keys (#3353)
  Manually make the date selector date a moment object (#3352)
  Fix filter panel size on services and marketplace pages (#3358)
  Tidy up org spce reducer logic
  Remove full stops from empty list messages - fixes #3340
  Fix search by space name in manage users space roles table - fixes #3329
  ...
KlapTrap added a commit that referenced this pull request Feb 11, 2019
* v2-master: (639 commits)
  Stop paginationResetPagination from added invalid fields
  Update status_updates.md
  Updates
  Patch the image version in the chart, so reuse-values can work
  Fix upgrade when using --reuse-values
  Avoid need to change service name
  Add test for upgrading with --reuse-values
  Fix for --reuse-values
  Fix helm repo link when geneating an RC (#3369)
  Improve handling of maxed state and observables (#3370)
  Update cf-api-v3.md
  v2/v3 api docs updates
  Fix create-services script used to set CF up for E2E tests
  Only prevent copy & paste in confirm dialog for production
  Fix for bug causing intermittment E2E Test failures on org tests (#3366)
  Allow e2e createService 3 attempts at creating service
  Weekly updaye 18 January (#3365)
  Change log for 2.3.0 (#3364)
  Ensure the loading indicator and the refresh button animated at the correct time. (#3363)
  Fix fetching of stats in app wall for some cases when list is maxed (#3360)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App Wall is making stats calls when it should not
3 participants