This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
Ensure the loading indicator and the refresh button animated at the correct time. #3363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Hey KlapTrap! The commit authors and yourself have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3363 +/- ##
=============================================
- Coverage 70.48% 70.46% -0.03%
=============================================
Files 661 661
Lines 29194 29194
Branches 6667 6670 +3
=============================================
- Hits 20578 20572 -6
- Misses 8616 8622 +6 |
richard-cox
approved these changes
Jan 18, 2019
KlapTrap
added a commit
that referenced
this pull request
Jan 29, 2019
* v2-master: (34 commits) v2/v3 api docs updates Fix create-services script used to set CF up for E2E tests Only prevent copy & paste in confirm dialog for production Fix for bug causing intermittment E2E Test failures on org tests (#3366) Allow e2e createService 3 attempts at creating service Weekly updaye 18 January (#3365) Change log for 2.3.0 (#3364) Ensure the loading indicator and the refresh button animated at the correct time. (#3363) Fix fetching of stats in app wall for some cases when list is maxed (#3360) Fix CF-Level Metrics permissions check (#3348) About Page Title customization support (#3356) Revert loading indicator fixes Fix app state to allow start action for offline while updating (#3350) Fix display of percent tooltip on metrics chart (#3361) Ensure the SCM type is included in store keys (#3353) Manually make the date selector date a moment object (#3352) Fix filter panel size on services and marketplace pages (#3358) Tidy up org spce reducer logic Remove full stops from empty list messages - fixes #3340 Fix search by space name in manage users space roles table - fixes #3329 ...
KlapTrap
added a commit
that referenced
this pull request
Feb 11, 2019
* v2-master: (639 commits) Stop paginationResetPagination from added invalid fields Update status_updates.md Updates Patch the image version in the chart, so reuse-values can work Fix upgrade when using --reuse-values Avoid need to change service name Add test for upgrading with --reuse-values Fix for --reuse-values Fix helm repo link when geneating an RC (#3369) Improve handling of maxed state and observables (#3370) Update cf-api-v3.md v2/v3 api docs updates Fix create-services script used to set CF up for E2E tests Only prevent copy & paste in confirm dialog for production Fix for bug causing intermittment E2E Test failures on org tests (#3366) Allow e2e createService 3 attempts at creating service Weekly updaye 18 January (#3365) Change log for 2.3.0 (#3364) Ensure the loading indicator and the refresh button animated at the correct time. (#3363) Fix fetching of stats in app wall for some cases when list is maxed (#3360) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The top blue loading indicator should show:
1a) When changing page
This happens in two cases:
1) On a none-local list.
2) On a list that is currently showing the "too many entities" message. See Scalability: Application Wall #2895
The refresh button should animate:
With one CF connected the apps list loads twice, this is fixed here #3313.
fixes #3305