Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Add cf/org/space links to service instance table using common components #3436

Merged
merged 12 commits into from
Apr 3, 2019
Merged

Add cf/org/space links to service instance table using common components #3436

merged 12 commits into from
Apr 3, 2019

Conversation

richard-cox
Copy link
Contributor

@richard-cox richard-cox commented Mar 19, 2019 •
edited
Loading

@richard-cox richard-cox self-assigned this Mar 19, 2019
@cfdreddbot
Copy link

✅ Hey richard-cox! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented Mar 25, 2019 •
edited
Loading

Codecov Report

Merging #3436 into v2-master will increase coverage by 0.1%.
The diff coverage is 81.63%.

@@             Coverage Diff              @@
##           v2-master    #3436     +/-   ##
============================================
+ Coverage      51.44%   51.54%   +0.1%     
============================================
  Files            697      699      +2     
  Lines          19418    19438     +20     
  Branches        3427     3434      +7     
============================================
+ Hits            9989    10019     +30     
+ Misses          9429     9419     -10

nwmac
nwmac approved these changes Mar 29, 2019
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-cox
e2e help
184eb78 
- allow more time for delete app test
- allow more time for setup/teardown http requests
- add logging for delete service instance (currently fails silently)
@richard-cox
Remove fdescribe and xit's
f1d13be
@richard-cox
Wait for connect dialog to be removed before waiting for snackbar
b872628
@richard-cox
Harden service helper
2df2487 
- move service instance name out of service helper
- attempt to delete a service instance up to three times
- don't attempt to delete an already deleted edited service instance
- more logging on failures
@richard-cox
Removed fdescribe....
944d405
@richard-cox
Connect endpoint tidy up
c2e01b9 
- removed unused code
- removed wait for connected snackbar. this is causing timesink issues
- improved snackbar e2e test waitformessage
- allow more time for cf/org/space test
@richard-cox richard-cox merged commit c34ee7e into v2-master Apr 3, 2019
@richard-cox richard-cox deleted the cf-org-space-values branch April 3, 2019 13:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees

@richard-cox richard-cox

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add cf/org/space label to service wall cards as per app wall
3 participants
@richard-cox @cfdreddbot @nwmac