This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
User provided application binding #3444
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed include relations list for GetAllUserProvidedServices - fixed schema --> entity typo in api.effect - use correct space schema in UserProvidedServiceInstanceSchema - ensure validateEntityRelations uses __forcedPageSchemaKey__ - if present validate the entity type's page number in pagination-reducer.helper
* v2-master: (23 commits) docs update Fix unit test Fix issues from review - Ensure extensions/extension-types.ts remains free from other imports - Now check endpoint detail type is correct at runtime - Cf Endpoint Type is now registered in cf package - Ensure cf package tests & lint execute correctly - Ensure endpoint details components are destroyed correctly Fix merge issue Fix merge issue More info Fix lint issues Priorities & tweaks Another lint fix Fix linting, don't show image if no image Disable endpoint card routerLink using new directive Missing images Fix existing getIconButton bug - There may be other places where this magically worked and now correctly won't Fix linting Tweak cf details Fix tests WIP WIP Fix unit tests Add endpoint type icons & custom endpoint details table column/card section ...
- Removed commented out code, fixed typos in comments and moved some comments to jsdoc format - use common service for create/update user provided service instance - remove un-needed code - fixed minor bugs - revert previous fix to populatePaginationFromParent (handling in parent, keeps original function cleaner) - ensure e2e tests run as user instead of admin
…ntities observables - Also removed some unused code
|
✅ Hey KlapTrap! The commit authors and yourself have already signed the CLA. |
|
Closing, now included as part of #3415 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to bind a new or previously created user provided service to an application.
This should include a bind step when creating or editing a user provided service instance and on the application services page.