File tree Expand file tree Collapse file tree 4 files changed +6
-3
lines changed Expand file tree Collapse file tree 4 files changed +6
-3
lines changed Original file line number Diff line number Diff line change
1
+ ---
2
+ ' @cloudfour/patterns ' : patch
3
+ ---
4
+
5
+ Comment permalinks now resolve to the hash URL of the comment ID rather than a nonexistent Timber ` comment.link ` property
Original file line number Diff line number Diff line change 20
20
await commentMarkup ( {
21
21
comment : {
22
22
ID : 1 ,
23
- link : '#comment-1' ,
24
23
date : new Date ( 'January 1 2000' ) ,
25
24
avatar : '' ,
26
25
author : {
Original file line number Diff line number Diff line change 51
51
<div class =" c-comment__meta" >
52
52
<div class =" c-comment__meta-detail" >
53
53
<a class =" c-comment__meta-link"
54
- href =" {{comment .link }}" >
54
+ href =" #comment- {{comment .ID }}" >
55
55
<span class =" c-comment__meta-icon" >
56
56
{% include ' @cloudfour/components/icon/icon.twig' with {
57
57
name : ' link' ,
Original file line number Diff line number Diff line change @@ -90,7 +90,6 @@ export const makeComment = ({
90
90
91
91
const result = {
92
92
ID : id ,
93
- link : `#comment-${ id } ` ,
94
93
date : new Date ( ) ,
95
94
avatar : `https://placeimg.com/92/92/${ sample ( placeImgCategories ) } ` ,
96
95
author : {
You can’t perform that action at this time.
0 commit comments