Dynamic Imports for Video Player #181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
colbyfayock
commented
Aug 26, 2023
| await mkdirp(distPath); | ||
|
|
||
| for ( const asset of assets ) { | ||
| const assetPath = await resolveAssetPath(asset); |
There was a problem hiding this comment.
i dont love this solution but couldn't figure out a way to resolve the node_modules reliably with being in a yarn workspace
12 tasks
colbyfayock
added a commit
that referenced
this pull request
Aug 28, 2023
# Description With the App Router, we no longer have access to the <Head component. CldVideoPlayer was utilizing this component in order to load a stylesheet, preventing the need to include it from the project, but without <Head, the player breaks. Given this is no longer an option, this includes the CSS and associated files on build so that they're able to be imported from within the App Router project, allowing the stylesheet to be imported for a working player. This is currently downloading the assets from unpkg, where the player is officially hosted, though future iterations may include these files from the cloudinary-video-player node_module, though thats currently on hold for performance reasons. See #181 This also deprecates the `version` prop as we're no longer able to reliably grab assets based on the configured version (or at all for that matter). In future versions using the node module, the assets will be synced based on the installed dependency via next-cloudinary without configuration available. ## Issue Ticket Number Fixes #248 <!-- Specify above which issue this fixes by referencing the issue number (`#<ISSUE_NUMBER>`) or issue URL. --> <!-- Example: Fixes https://github.com/colbyfayock/next-cloudinary/issues/<ISSUE_NUMBER> --> ## Type of change <!-- Please select all options that are applicable. --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Fix or improve the documentation - [ ] This change requires a documentation update # Checklist <!-- These must all be followed and checked. --> - [ ] I have followed the contributing guidelines of this project as mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md) - [ ] I have created an [issue](https://github.com/colbyfayock/next-cloudinary/issues) ticket for this PR - [ ] I have checked to ensure there aren't other open [Pull Requests](https://github.com/colbyfayock/next-cloudinary/pulls) for the same update/change? - [ ] I have performed a self-review of my own code - [ ] I have run tests locally to ensure they all pass - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes needed to the documentation
cham74
added a commit
to cham74/next-image-delivery
that referenced
this pull request
Dec 23, 2023
# [4.19.0](cloudinary-community/next-cloudinary@v4.18.1...v4.19.0) (2023-08-28) ### Features * CldVideoPlayer support for Next.js 13 App Router ([#265](cloudinary-community/next-cloudinary#265)) ([8674b95](cloudinary-community/next-cloudinary@8674b95)), closes [#181](cloudinary-community/next-cloudinary#181) [#248](cloudinary-community/next-cloudinary#248)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This dynamically loads in the Cloudinary Video Player via the npm package.
It makes the
versionprop that was previously available to control the downloaded assets unavailable due to it now being loaded as a package dependency.It also copies over assets from the node module, particularly CSS and Fonts (icons) to make available to load from the page adding the player which is needed in the App Router.
Issue Ticket Number
Fixes #180
Type of change
Checklist