Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add load and error events to cldimage #96

Merged

Conversation

codercatdev
Copy link
Contributor

@codercatdev codercatdev commented Mar 6, 2024

Description

Issue Ticket Number

Fixes #88

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Fix or improve the documentation
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

Copy link

vercel bot commented Mar 6, 2024

@codercatdev is attempting to deploy a commit to the Cloudinary DevX Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Mar 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-cloudinary ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 6:20pm

@colbyfayock
Copy link
Contributor

hey @codercatdev tested this locally and it works great, thank you!

I'm going to hold off on merging for a minute, we're going to be reverting ENV configuration that was recently released, which should have been on a major release (breaking change) and not sure if we want to do that revert before merging in new stuff

@ghostdevv ghostdevv self-requested a review March 11, 2024 02:14
@ghostdevv ghostdevv changed the title add events to cldimage feat: add load and error events to cldimage Mar 11, 2024
@ghostdevv ghostdevv merged commit d6523a5 into cloudinary-community:main Mar 11, 2024
4 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 11, 2024
# [1.3.0](v1.2.4...v1.3.0) (2024-03-11)

### Features

* add load and error events to cldimage ([#96](#96)) ([d6523a5](d6523a5))
Copy link
Contributor

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Mar 12, 2024
# [1.3.0-beta.1](v1.2.4...v1.3.0-beta.1) (2024-03-12)

### Features

* add load and error events to cldimage ([#96](#96)) ([d6523a5](d6523a5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Expose on:load event on CldImage
3 participants