Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small build and usage issues #1

Closed
erickok opened this issue Apr 25, 2013 · 2 comments
Closed

Small build and usage issues #1

erickok opened this issue Apr 25, 2013 · 2 comments

Comments

@erickok
Copy link

erickok commented Apr 25, 2013

Thanks for providing an Android-specific version, much better than the dependencies that came with the general Java version. Just some small remarks.

The readme provides a link to the compiled .jar (http://res.cloudinary.com/cloudinary/raw/upload/cloudinaryandroid-1.0.0.jar), but it leads to nothing. Also not sure if it should, as this is an Android library now.

The Cloudinary folder, with the Android library project, does not contain a 'res' folder. This causes the build to fail and pops up some messages that may be misleading to newer developers.

The way Cloudinary (configuration) objects are initialez by providing a Map of Objects could be improved. It is not type safe and requires unnecessary use of String constants. I would much prefer it if it used a builder pattern like the Cloudinary class itself. The same holds for the supplying of options to the uploader(). Instead of a (non-parametized) Map I prefer a builder pattern or even just nullable parameters to the upload() method.

@TalLevAmi
Copy link
Contributor

Thank you for your feedback.

Jar - the link seems for be working for me. Can you please try again?
res folder - added.
Type safe constructor and upload parameters - we will take this into account for future versions of the library.

@erickok
Copy link
Author

erickok commented Apr 25, 2013

You are right, the download does work if I use wget. Must be Chromium or something. Thanks for considering the type safity issues in future versions.

nitzanj pushed a commit that referenced this issue Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants