-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small build and usage issues #1
Comments
TalLevAmi
added a commit
that referenced
this issue
Apr 25, 2013
Thank you for your feedback. Jar - the link seems for be working for me. Can you please try again? |
You are right, the download does work if I use wget. Must be Chromium or something. Thanks for considering the type safity issues in future versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thanks for providing an Android-specific version, much better than the dependencies that came with the general Java version. Just some small remarks.
The readme provides a link to the compiled .jar (http://res.cloudinary.com/cloudinary/raw/upload/cloudinaryandroid-1.0.0.jar), but it leads to nothing. Also not sure if it should, as this is an Android library now.
The Cloudinary folder, with the Android library project, does not contain a 'res' folder. This causes the build to fail and pops up some messages that may be misleading to newer developers.
The way
Cloudinary
(configuration) objects are initialez by providing aMap
of Objects could be improved. It is not type safe and requires unnecessary use of String constants. I would much prefer it if it used a builder pattern like theCloudinary
class itself. The same holds for the supplying of options to theuploader()
. Instead of a (non-parametized)Map
I prefer a builder pattern or even just nullable parameters to theupload()
method.The text was updated successfully, but these errors were encountered: