Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Included checks for windows user #5

Merged
merged 2 commits into from
Feb 19, 2020
Merged

Included checks for windows user #5

merged 2 commits into from
Feb 19, 2020

Conversation

gitdmishra
Copy link
Contributor

included check for

  • python version
  • pip version
  • virtual environment
  • User name

laszewsk
laszewsk approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@laszewsk laszewsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use Console.error to report if things are not ok

this way we can execute all the tests instead of interrupting with an exception, but i have not looked at this closely,

@laszewsk laszewsk merged commit d2e23a1 into cloudmesh:master Feb 19, 2020
laszewsk added a commit that referenced this pull request Mar 23, 2020
@laszewsk
Merge pull request #5 from gitdmishra/master
60ff36c 
Included checks for windows user
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laszewsk laszewsk laszewsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gitdmishra @laszewsk