Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve formGroupErrors when dealing with a FormArray #116

Merged
merged 2 commits into from
Nov 28, 2019
Merged

improve formGroupErrors when dealing with a FormArray #116

merged 2 commits into from
Nov 28, 2019

Conversation

maxime1992
Copy link
Contributor

No description provided.

@maxime1992 maxime1992 added scope: lib Anything related to the library itself effort-1: minutes Will only take a few minutes to fix/create type: bug/fix This is a bug or at least needs a fix workaround: none No workaround labels Nov 26, 2019
@maxime1992 maxime1992 self-assigned this Nov 26, 2019
@maxime1992 maxime1992 force-pushed the fix/form-array-error-empty-array branch from 369cffe to a6ee890 Compare November 26, 2019 17:58
@maxime1992 maxime1992 changed the title [WIP] fix(lib): when accessing formGroupErrors, a FormArray with no errors returns an empty array instead of null fix(lib): when accessing formGroupErrors, a FormArray with no errors returns an empty array instead of null Nov 26, 2019
@maxime1992 maxime1992 force-pushed the fix/form-array-error-empty-array branch from a6ee890 to 0eccda9 Compare November 26, 2019 18:02
@maxime1992 maxime1992 changed the title fix(lib): when accessing formGroupErrors, a FormArray with no errors returns an empty array instead of null improve formGroupErrors when dealing with a FormArray Nov 26, 2019
zakhenry
zakhenry previously approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@zakhenry zakhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, feel free to merge when fixed up

@maxime1992 maxime1992 force-pushed the fix/form-array-error-empty-array branch from 0eccda9 to 13c2535 Compare November 28, 2019 10:02
@maxime1992 maxime1992 merged commit 2499b90 into master Nov 28, 2019
@maxime1992
Copy link
Contributor Author

🎉 This PR is included in version 3.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@maxime1992 maxime1992 deleted the fix/form-array-error-empty-array branch December 18, 2019 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakhenry zakhenry zakhenry approved these changes

Assignees

@maxime1992 maxime1992

Labels
effort-1: minutes Will only take a few minutes to fix/create released scope: lib Anything related to the library itself type: bug/fix This is a bug or at least needs a fix workaround: none No workaround
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxime1992 @zakhenry