Feat support angular 16 #299
Conversation
|
LGTM, thanks for the PR. Please rebase the commits in 1 commit and mark that commit as a breaking change (see previous commits on major version bumps for ngx sub form for examples). This is for semantic versioning as we've got automatic releases and it wouldn't bump to v9 of the lib otherwise |
BREAKING CHANGE: Angular 16 required This closes cloudnc#298 Also wanted to to upgrade typescript to a 5.x.x version, but the Cypress typescript compilation failed, because of cypress-io/cypress#26203
erikmom
force-pushed
the
feat-support-angular-16
branch
from
244c55e
to
821e2a3
Compare
|
@maxime1992 I've squashed the commits and updated the commit message. Let me know if I need to do more! |
|
LGTM thanks :) |
|
@erikmom after the upgrade master started to fail. I dug into this for about an hour and still no success. Can you please have a look on your side? If it's a quick fix awesome, if it's not I'll have to revert the changes until we can figure it out |
|
Hey @maxime1992, I saw in Github actions that the linting failed and I could reproduce it locally as well. I've recreated the pull request with two fixes:
|
|
🎉 This PR is included in version 9.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.