Fix build on push + occasional failing builds #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schnatterer
changed the title
While working on f85356f. Using consistent terms makes the code easier to understand.
Because jenkins regularly fails with this: TRACE c.c.gitops.utils.CommandExecutor - Executing command: 'ip route get 1' 13:25:54 java.lang.RuntimeException: Could not determine local ip address, because command 'ip route get 1' returned: '' If we keep having problems with this, we might just remove the whole localAddress part, see comment in the code.
yannickchristhomas
force-pushed
the
feature/fix-build-on-push
branch
from
aafa456
to
b0c18b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 1
Inside the GOP Jenkins build did no longer start automatically when pushing into the appropriate repo ins SCM-Manager.
Bug 2
Jenkins regularly fails with this:
Work around this by implementing
ip route get 1Groovy-natively.