GOP Tools upgrade #189
Merged
GOP Tools upgrade #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Johannes Schnatterer <johannes.schnatterer@cloudogu.com>
Co-authored-by: Johannes Schnatterer <johannes.schnatterer@cloudogu.com>
Migrate from bash to groovy, while on it. Why migrate? System Property scm.initialPassword and scm.initialUser seem to no longer work. Instead. we can now use env vars via "extraEnv" value. However, these are a string, not an object. This makes them very hard to set via helm CLI. So instead of fiddling through the bash quoting hell, I decided to move to a templated values.yaml which makes the whole process easier to read and maintain. While migrating to groovy, it seemed that the logic of scmm.url and .host is more complex than necessary. Also the "scmm-scm-manager.default.svc.cluster.local" is repeated in multiple classes instead of being centralized in ApplicationConfigurator . Refactoring those would have been a good idea but was too much for the current scope: Upgrading SCMM. Migrating to groovy is a good first step. Let's do the refactoring next time. BTW: init-scmm.sh IS_LOCAL was unused and could be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.