Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/import config file #194

Merged
merged 7 commits into from
May 29, 2024
Merged

Feature/import config file #194

merged 7 commits into from
May 29, 2024

Conversation

movray
Copy link
Contributor

@movray movray commented May 28, 2024

No description provided.

movray and others added 7 commits May 29, 2024 11:40
We don't want to write our own validator.
I think it's muss less complex to solve this problem using configuration
 of the SchemaGenerator.
This will make it easier to use in the future without having to cast it
@schnatterer
Copy link
Member

schnatterer commented May 29, 2024

I tested this successfully with this config

# $schema: docs/configuration.schema.json
features:
  ingressNginx:
    active: true
    helm:
      values:
        controller:
          replicaCount: 4
          #extraArgs:
          #  default-ssl-certificate: "ingress-nginx/wildcard-cert"
          service:
            externalTrafficPolicy: Local
            internal:
              enabled: true
              annotations:
                service.beta.kubernetes.io/azure-load-balancer-internal: "true"
                service.beta.kubernetes.io/azure-load-balancer-health-probe-request-path: "/healthz"
 docker run --rm -t  -u $(id -u)  \
    -v ~/.config/k3d/kubeconfig-gitops-playground.yaml:/home/.kube/config \
    -v $(pwd)/gitops-playground.yaml:/config/gitops-playground.yaml \
    --net=host \
  gitops-playground:dev -x --yes --argocd --ingress-nginx --base-url=http://localhost  --config-file=/config/gitops-playground.yaml

BTW, setting the wildcard cert commented above can be tested like so

 openssl req -x509 -nodes -days 365 -newkey rsa:2048 -keyout tls.key -out tls.crt -subj "/CN=localhost"                                  
kubectl create secret tls wildcard-cert --cert=tls.crt --key=tls.key -n ingress-nginx

@schnatterer schnatterer merged commit 8c1c4f8 into main May 29, 2024
1 check passed
@schnatterer schnatterer deleted the feature/import_config_file branch May 29, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants