Prometheus: watch CRs in all namespaces #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schnatterer
force-pushed
the
feature/prometheus-all-namespaces
branch
2 times, most recently
from
bfd334d
to
649aa94
Compare
This allows application to create ServiceMonitors in their own namespace
.
Fits much better with our least privilege and multi-tenancy approaches.
On top of that remove the need to add a label to each ServiceMonitor.
This makes them easier to use.
Note that
any: true
instead of
matchLabels: {}
as described here:
prometheus-community/helm-charts#106
fails, because not in schema.
schnatterer
force-pushed
the
feature/prometheus-all-namespaces
branch
from
649aa94
to
136f917
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows application to create ServiceMonitors in their own namespace .
Fits much better with our least privilege and multi-tenancy approaches.
You can validate if it works by solving this exercise:
https://cloudogu.github.io/workshop-cloudland24/#/exercise-monitoring