Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/issue 53 #57

Merged
merged 9 commits into from
Aug 4, 2021
Merged

Feature/issue 53 #57

merged 9 commits into from
Aug 4, 2021

Conversation

schnatterer
Copy link
Member

@schnatterer schnatterer commented Aug 3, 2021 •
edited
Loading

Fixes #53 and #56.

While on it I also fixed this and that:

  • Upgraded Jenkins Helm Chart (hoping to fix argocd/nginx and fluxv1/nginx won't build on remote cluster #55 which it didn't. Still latest version has less vulns)
  • apply.sh: Print localhost instead of external IP.
  • Make argo accessible via localhost:9092 (implied upgrade of argocd chart)
  • README: Fix TLDR command.
  • README: Reduce amount of options for sake of simplicity.

@schnatterer
Provide solution for failing builds in playground on docker push #53
15d1bba
@schnatterer
apply.sh: Use same kubectl version as in Dockerfile
9235b5b
@schnatterer
Extend README to address #56
a456e6f
@schnatterer
Update Jenkins Chart and plugins.
b949ef5 
Newer plugins, less vulns. But does not fix #55.
@schnatterer
#53 Init cluster: Fall back to arbitrary port if netstat not present
a95178c 
This happens to be the case on our Jenkins agent images, resulting in failing concurrent builds.
@schnatterer
apply.sh: Print localhost instead of external IP.
ea805d6 
If possible. This address is later printed on the welcome screen, where localhost is much more constant and intuitive as the the external address. Also Jenkins notifications only work on localhost, not external addresses.
@schnatterer schnatterer force-pushed the feature/issue-53 branch 4 times, most recently from beb6321 to b12d390 Compare August 4, 2021 14:20
@schnatterer
README: Reduce amount of options for sake of simplicity.
f800709 
We suggest to use
* docker run for applying to local cluster
* kubectl run for applying to remote cluster

This way it's simpler to understand for the user and we have less test cases to support.
Also the "localhost" change of the last commit works as intended.

Using the script directly is no longer supported officially.
@schnatterer
Make argo accessible via localhost:9092.
7cc1c80 
Before it was only available via external IP, even when running locally.
@marekzan marekzan merged commit 35325b1 into main Aug 4, 2021
@marekzan marekzan deleted the feature/issue-53 branch August 4, 2021 17:01
@schnatterer schnatterer mentioned this pull request Aug 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@schnatterer @marekzan