Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/94 k8s registry lib #96

Merged
merged 31 commits into from
Aug 2, 2024
Merged

Feature/94 k8s registry lib #96

merged 31 commits into from
Aug 2, 2024

Conversation

sklein94
Copy link
Contributor

@sklein94 sklein94 commented Aug 1, 2024

Resolves #94

kahoona77
kahoona77 requested changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@kahoona77 kahoona77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found some minor issues.
Looks good 👍

Dockerfile Outdated Show resolved Hide resolved
app/setup/data/registryConfigurationWriter.go Outdated Show resolved Hide resolved
app/setup/data/registryConfigurationWriter.go Outdated Show resolved Hide resolved
app/setup/data/registryConfigurationWriter.go Outdated Show resolved Hide resolved
app/setup/data/registryConfigurationWriter.go Outdated Show resolved Hide resolved
app/setup/starter.go Outdated Show resolved Hide resolved
app/setup/starter.go Outdated Show resolved Hide resolved
app/setup/starter.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
k8s/helm/values.yaml Outdated Show resolved Hide resolved
sklein94 and others added 18 commits August 1, 2024 09:41
@sklein94 @kahoona77
Update Dockerfile
25a4ff5 
Co-authored-by: kahoona77 <benjamin.ernst@cloudogu.com>
@sklein94 @kahoona77
Update app/setup/data/registryConfigurationWriter.go
f6c5a50 
Co-authored-by: kahoona77 <benjamin.ernst@cloudogu.com>
@sklein94 @kahoona77
Update app/setup/data/registryConfigurationWriter.go
8a70c02 
Co-authored-by: kahoona77 <benjamin.ernst@cloudogu.com>
@sklein94 @kahoona77
Update app/setup/data/registryConfigurationWriter.go
9a0b057 
Co-authored-by: kahoona77 <benjamin.ernst@cloudogu.com>
@sklein94 @kahoona77
Update app/setup/data/registryConfigurationWriter.go
d6f0f84 
Co-authored-by: kahoona77 <benjamin.ernst@cloudogu.com>
@sklein94 @kahoona77
Update app/setup/starter.go
50e6067 
Co-authored-by: kahoona77 <benjamin.ernst@cloudogu.com>
@sklein94 @kahoona77
Update app/setup/starter.go
cb32cd5 
Co-authored-by: kahoona77 <benjamin.ernst@cloudogu.com>
@sklein94 @kahoona77
Update app/setup/starter.go
7c66bb7 
Co-authored-by: kahoona77 <benjamin.ernst@cloudogu.com>
@sklein94 @kahoona77
Update app/setup/starter.go
725e3f0 
Co-authored-by: kahoona77 <benjamin.ernst@cloudogu.com>
@sklein94 @kahoona77
Update go.mod
bc3d55f 
Co-authored-by: kahoona77 <benjamin.ernst@cloudogu.com>
@sklein94 @kahoona77
Update k8s/helm/values.yaml
e194faf 
Co-authored-by: kahoona77 <benjamin.ernst@cloudogu.com>
@kahoona77
update go.sum
95cda64
@sklein94
#94 Update changelog
96888d4
@sklein94
Merge branch 'feature/94_k8s-registry-lib' of ssh://github.com/cloudo…
4ecc222 
…gu/k8s-ces-setup into feature/94_k8s-registry-lib
@sklein94
#94 Remove etcd
566f92a
@sklein94
#94 Remove key provider and node master steps
cb44c8c
@sklein94
#94 write sensitive dogu config directly to secrets
3d5ce7d
@sklein94
#94 Update registry-lib to v0.2.2
19beb6b
kahoona77
kahoona77 approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@kahoona77 kahoona77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kahoona77 kahoona77 merged commit 483bd85 into develop Aug 2, 2024
1 check passed
@kahoona77 kahoona77 deleted the feature/94_k8s-registry-lib branch August 2, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kahoona77 kahoona77 kahoona77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use k8s-registry-lib
2 participants
@sklein94 @kahoona77