Enable dogu upgrades #46

jsprey · 2022-09-27T13:55:33Z

Resolves #40

The dogu upgrade version comes from the CR

…riting

The needed state of the DoguUpgradeManager was too hefty so testing was a PITA

The doguUpgradeManager already adds the reason for the error.

…iff lib

Health checks test dogu states during a point-in-time which may change later-on. These errors are by definition requeueable because these checks may succeed once the dogus in question are healthy. The requeueable error implements three interfaces: - Error for obvious reasons - Unwrap to provide the original error - requeuableError so the controller can requeue the pending operation again at some point later

Removes the copy of the .git folder into the context of the docker build as every change in the repository lead to an invalidation of all cached layers

… stages Removes the different cacheDir for the stages `development` and `production`. Now, all downloaded dogus are cached inside the folder `/tmp/dogu-registry-cache`.

api/v1/dogu_types.go

controllers/cesregistry/dogu_registrator.go

controllers/doguDeleteManager_test.go

controllers/doguUpgradeManager.go

controllers/doguUpgradeManager_test.go

controllers/interfaces.go

controllers/resource/upserter.go

controllers/upgrade/premisesChecker.go

controllers/upgrade/premisesChecker_test.go

controllers/upgradeabilityChecker.go

docs/development/reconciliation_de.md

docs/development/reconciliation_en.md

The current build process acts sometimes weird and has two crashloop pods for a deployment when there should only be one. The reason is that the default deployment strategy goes for rolling updates which does not bode well during the startup where one will crash. This commit changes the deployment strategy to recreate the pod which has the drawback of downtime. This drawback is only a minor hindrance because the operator has a fast spinup time.

ppxl added 30 commits September 8, 2022 13:44

#40 Build dogu upgrade manager stub

913e9b1

#40 Stub base methods for upgrading

6b5f4b8

#40 TDD checkUpgradeability,checkDoguIdentity,checkVersionBeforeUpgrade

3eb61b6

#40 TDD checkDoguHealth, checkUpgradeability

8d22283

#40 TDD move health checks to own package bcs of complexity

0318e76

#40 TDD implement recursive mandatory and optional dogu health checks

bef7729

#40 Remove debug output

c819177

#40 Fix component integration tests

d8cd647

#40 Add positive test

2d220e4

#40 TDD getDogusForResource

2abcc09

The dogu upgrade version comes from the CR

#40 TDD split interfaces for more implementation independence

14501ec

#40 Add event logging

94bcb81

#40 Fix typos

1a2cdab

#40 Add upgrade config struct

d407814

#40 TDD extract variables, fix upgradeability check, simplify event w…

64aab5b

…riting

#40 naively implement upgrade step execution

c9e2c92

#40 Add dogu status "upgrading"

c9662ba

#40 TDD extract business steps into upgrade package for simpler code

282a1fc

The needed state of the DoguUpgradeManager was too hefty so testing was a PITA

#40 TDD extract business steps into upgrade package for simpler code

13d60c7

The needed state of the DoguUpgradeManager was too hefty so testing was a PITA

#40 Introduce force upgrade switch to dogu CRD

d6a9749

#40 Add another Event method, rename dogus in integration method

c5b42bc

#40 Make things weird, I have no idea what I am doing

062f562

#40 Reduce folding depth for more readability

3454fa5

#40 Empty implementation of the upgrade phase layout

560f9ed

#40 Omit new dogu resource fields for json marshalling

14fea0c

#40 Rename resourceGenerator getter to CreateXYZZY

da3e6b9

#40 Add Dogu changeState() for more convenient status setting

5f455e8

#40 Replace integration method for dogu state change with native method

4e8bc16

#40 WIP

0e10832

#40 Fix wrong early-exit extraction

291a697

ppxl and others added 16 commits September 23, 2022 14:26

#40 Remove duplicate error reasons

c30fce6

The doguUpgradeManager already adds the reason for the error.

#40 Add test

66ba6f4

#40 Add test for previously missing error case

1a415aa

#40 Extract repeated error message

6a79749

#40 Fix possible nil pointer in debug predicate, replace deprecated d…

afd6000

…iff lib

#40 Add syntax suger to decide which requeue action will trigger

e55949f

#40 Make k8s-dogu-operator selectable via labels

2256d0f

#40 Improve docker build stability

8d8bd92

Removes the copy of the .git folder into the context of the docker build as every change in the repository lead to an invalidation of all cached layers

#40 Simplifies the deployment of the k8s-dogu-operator into different…

a982f9b

… stages Removes the different cacheDir for the stages `development` and `production`. Now, all downloaded dogus are cached inside the folder `/tmp/dogu-registry-cache`.

#40 Template log level into deployment when building via Makefile

e256398

#40 Fixes Unit tests

4766f89

#40 Reduce complexity for smell reported by the sonar cube analysis

79b5a5e

#40 Add integration test for the upgrade manager (wip)

60c1c6e

Fix upgrade integration test. #40

a71aa47

#40 extract boolean check to reduce complexity

ff2caaa

jsprey commented Sep 27, 2022

View reviewed changes

nhinze23 and others added 2 commits September 27, 2022 17:45

Fix integration test #40

8d3a962

#40 document reconciliation

2bdbddf

jsprey commented Sep 28, 2022

View reviewed changes

jsprey and others added 6 commits September 28, 2022 13:04

#40 apply review feedback

e76ed73

#40 replace inline mock with mockery mock

f1960d4

Add dogu resource scheme from custom resources to actual scheme #40

07ecb19

#40 Add more events for meaningful upgrade actions

9bfd711

#40 Fix possible log level parsing, add minimal start-up info

ca4e898

ppxl merged commit 172eef3 into develop Sep 29, 2022

ppxl deleted the feature/40_upgrade_dogus branch September 29, 2022 07:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable dogu upgrades #46

Enable dogu upgrades #46

jsprey commented Sep 27, 2022

Enable dogu upgrades #46

Enable dogu upgrades #46

Conversation

jsprey commented Sep 27, 2022